test-case: check-alsabat.sh: Lower the threshold for detecting tones #991
Conversation
singalsu
force-pushed
the
alsabat_adjust_k_threshold
branch
2 times, most recently
from
afeb0ae to
66417b9
Compare
|
suspend/resume failure in https://sof-ci.01.org/softestpr/PR991/build110/devicetest/index.html is unrelated, other tests are passing. |
The default parameter sigma k is 3.0 when omitted from command line. This patch drops the threshold to half with 1.5 to better detect distortion in playback. Alsabat judges spectral components above the threshold as sine frequencies. This change should increase the probability fail a test to avoid green failures to happen. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
alsabat_adjust_k_threshold
branch
from
66417b9 to
4c8a02a
Compare
|
Removed now revert to 997 Hz. |
|
Ready, the two fails look unrelated. |
|
I don't know whether https://sof-ci.01.org/softestpr/PR991/build119/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-alsabat-headset-playback is related or not but it's in the same test so let's not merge this yet Also spotted by @plbossart in https://sof-ci.01.org/linuxpr/PR4101/build2529/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-alsabat-headset-playback on a different device of the same model |
It's not related, #992 can fix it. |
|
I tested this PR with #992, the results are as expected: |
|
SOFCI TEST |
|
Only suspend/resume failure that this test does not change: merging |
|
@fredoh9 confirmed in internal issue 379 that reverting this makes some tests pass/green fail again. |
|
Not sure why 821 Hz only fails with this fix. If the change affects the test results directly, let's not merge the change until everything is under control. |
4 participants
The default parameter sigma k is 3.0 when omitted from command line. This patch drops the threshold to half with 1.5 to better detect distortion in playback. Alsabat judges spectral components above the threshold as sine frequencies.
This change should increase the probability fail a test to avoid green failures to happen.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com