Skip to content

Conversation

@kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Dec 7, 2022

Lower the default test frequency from 997Hz to 821Hz. Most SOF topologies use 1000Hz tick rate, and test frequency close to this scheduling frequency can mask certain type of errors (like SOF bug

Link: thesofproject/sof#6709
Suggested-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

cc:

Lower the default test frequency from 997Hz to 821Hz. Most SOF
topologies use 1000Hz tick rate, and test frequency close to this
scheduling frequency can mask certain type of errors (like SOF bug

Link: thesofproject/sof#6709
Suggested-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i requested a review from a team as a code owner December 7, 2022 10:40
@kv2019i
Copy link
Contributor Author

kv2019i commented Dec 7, 2022

Tests for tests:

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 19, 2022

@singalsu, @kv2019i , @lgirdwood should we run this test multiple times with a different frequency each time? If yes please provide a list.

@singalsu
Copy link
Contributor

singalsu commented Dec 20, 2022

@singalsu, @kv2019i , @lgirdwood should we run this test multiple times with a different frequency each time? If yes please provide a list.

Yes, 599, 821, 997 Hz. But need to add also -k parameter, see #991.

997 Hz because it's a de-facto test frequency in industry. 599 Hz is another prime that I came up, could be some other prime as well.

Would someone have time to make a patch and include the -k stuff too?

@keqiaozhang
Copy link
Contributor

Would someone have time to make a patch and include the -k stuff too?

@singalsu , I have added 3 alsabat cases to cover 599, 821 and 997 in CI web, we can pass the frequency to check-alsabat.sh with -F option, no need to make a patch.

Test reports:
IPC4:https://sof-ci.sh.intel.com/#/result/planresultdetail/19411
MTL:https://sof-ci.sh.intel.com/#/result/planresultdetail/19409

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 22, 2022

@keqiaozhang #991 is not about passing the frequency, it adds a new sigma parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants