SKIP check-sof-logger if is_zephyr #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less is more. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
"exit 2" was not very intuitive Signed-off-by: Marc Herbert <marc.herbert@intel.com>
See thesofproject/sof#4420 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
No shellcheck warning in lib.sh or check-sof-logger.sh at https://github.com/thesofproject/sof-test/pull/724/checks?check_run_id=2957522764 No new warnings in other files |
Collaborator
Author
paulstelian97
approved these changes
Jul 1, 2021
aiChaoSONG
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add new skip_test() function