sof-process-state: print errors on stderr #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
https://travis-ci.org/github/thesofproject/sof-test/jobs/744364626 show no new shellcheck warning. |
Collaborator
Author
|
For https://sof-ci.01.org/softestpr/PR522/build411/devicetest/ APL_UP2_HDA was not available, everything else is PASS |
... because its normal output is typically discarded. This would have avoided regression 202507f / thesofproject#497 fixed by thesofproject#521. This could help with other multi pipelines issues. Also add a documentation header so not everyone has to read the entire code. When a process is not found just say so. No need for guesses and interpretations. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
xiulipan
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because its normal output is typically discarded.
This would have avoided regression 202507f / #497 fixed by #521.
This could help with other multi pipelines issues.
Also add a documentation header so not everyone has to read the entire
code.
Also add a warning about the massive copy/paste across
multiple-pipeline-playback and multiple-pipeline-capture (these are the
heaviest sof-process-state users).
Signed-off-by: Marc Herbert marc.herbert@intel.com