add User space test cases (version2) #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
requested changes
Nov 5, 2020
Collaborator
There was a problem hiding this comment.
Very quick and incomplete review.
The code is very readable, thanks! but I'm wondering whether all of it is really needed, especially the long pactl parser
Maybe there's no need for that much manual error handling either, relying on the defaults could be enough.
Contributor
|
@libinyang Ping for update or close. |
Add the helper function to check whether pulseaudio runs properly or not. Signed-off-by: Libin Yang <libin.yang@intel.com>
Check the pulseaudio card info to make sure the card is ready. Signed-off-by: Libin Yang <libin.yang@intel.com>
Add the tool pactlinfo.py to parse the pactl list information Signed-off-by: Libin Yang <libin.yang@intel.com>
This test case will go through all the sinks on the tested cards, and try to paplay it if the active port is not "not available" Signed-off-by: Libin Yang <libin.yang@intel.com>
This test case will go through all the sources on the tested cards, and try to parecord it if the active port is not "not available" Signed-off-by: Libin Yang <libin.yang@intel.com>
Contributor
Author
|
All the feedbacks are ACKed except the 'timeout' issue keeps open. |
Contributor
Author
|
ping for review |
xiulipan
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of changes have been made from the first version. And we have a full talk about the implementation. So open a new thread based on @marc-hb 's suggestion. The old version can be found: #363
This patchset includes:
check-userspace-cardinfo: check pulseaudio can parse the ucm correctly and exports the correct card
check-userspace-paplay: go through all the active sinks and play on it if port is available
check-userspace-parecord: go through all the active sources and record on it if port is available