tools: sof-kernel-dump: use journalctl command to query kernel log #251
Conversation
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I haven't read all the deleted code but if you are sure this is not losing any feature then this is great.
use journalctl command instead of this step: 1. get kernel bootup line number by sof-get-kernel-line.sh 2. user step 1 information to dump the kernel log from /var/log/kern.log file now direct use journalctl to dump the kernel log after system bootup Signed-off-by: Wu, BinX <binx.wu@intel.com>
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
LGTM except I still didn't check the deleted code, sorry.
In the future maybe this entire script could become just a small function in lib.sh? (Not now)
| boot_number=${1:-0} | ||
|
|
||
| # format time stamp output for journalctl command | ||
| LC_TIME='en_US.UTF-8' |
There was a problem hiding this comment.
This should really be the default locale on all test systems. update-locale seems to be the CLI tool for the job (not tested)
There was a problem hiding this comment.
so force update for DUT?
Current with the check and diff older style, so add this for format output
yes, it become more easy to understand with older one |
3 participants
use journalctl command instead of this step:
now direct use journalctl to dump the kernel log after system bootup
Signed-off-by: Wu, BinX binx.wu@intel.com