logging_ctl.sh: change log aliases to functions #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `dlog*` aliases to functions. Signed-off-by: Marc Herbert <marc.herbert@intel.com> Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Merged
marc-hb
previously approved these changes
Jul 24, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Jenkins did not run yet.
marc-hb
reviewed
Jul 24, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
This unfortunately does not seem to work, makes all the log levels replaced by REMOTE_...
2025-07-24 14:59:13 UTC [REMOTE_INFO] ktime=1669 sof-test PID=16342: starting
2025-07-24 14:59:13 UTC [REMOTE_INFO] Starting /usr/local/bin/mtrace-reader.py >& /home/ubuntu/sof-test/logs/multiple-pipeline/2025-07-24-14:59:13-887/mtrace.txt &
2025-07-24 14:59:13 UTC [REMOTE_INFO] /home/ubuntu/sof-test/test-case/multiple-pipeline.sh will use topology /usr/lib/firmware/intel/sof-ipc4-tplg/sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg to run the test case
2025-07-24 14:59:13 UTC [REMOTE_INFO] Pipeline list to ignore is specified, will ignore 'pcm=HDA Digital' in test case
2025-07-24 14:59:13 UTC [REMOTE_INFO] Run command to get pipeline parameters
2025-07-24 14:59:13 UTC [REMOTE_COMMAND] sof-tplgreader.py /usr/lib/firmware/intel/sof-ipc4-tplg/sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg -f 'type:any & ~pcm:Amplifier Reference & ~pcm:HDMI' -b ' pcm:HDA Digital' -s 0 -e
2025-07-24 14:59:14 UTC [REMOTE_INFO] ===== Testing: (Loop: 1/1) =====
2025-07-24 14:59:14 UTC [REMOTE_INFO] /home/ubuntu/sof-test/test-case/multiple-pipeline.sh will use topology /usr/lib/firmware/intel/sof-ipc4-tplg/sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg to run the test case
2025-07-24 14:59:14 UTC [REMOTE_INFO] Pipeline list to ignore is specified, will ignore 'pcm=HDA Digital' in test case
marc-hb
approved these changes
Jul 25, 2025
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Never mind: the logs have been like this for a long time. I have no idea why and since how long and it's not great IMHO. But this PR does not change anything there and is good to go.
Here's a months old example: https://sof-ci.01.org/softestpr/PR1268/build1020/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=verify-tplg-binary
2025-04-11 11:57:55 UTC [REMOTE_INFO] ktime=142 sof-test PID=2394: starting
2025-04-11 11:57:55 UTC [REMOTE_INFO] Checking topology file: /usr/lib/firmware/intel/development/sof-mtl-nocodec.tplg with sof-tplgreader.py
2025-04-11 11:57:55 UTC [REMOTE_INFO] Found file: /usr/lib/firmware/intel/development/sof-mtl-nocodec.tplg f5f016d0faa2f0739ff6f9e18f5dab80
2025-04-11 11:57:55 UTC [REMOTE_INFO] Valid pipeline(s) in this topology:
Member
Author
all the log entries with |
kv2019i
approved these changes
Aug 14, 2025
singalsu
approved these changes
Aug 14, 2025
Collaborator
|
I just noticed this gem of a hack 10 lines above... sigh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
dlog*aliases to functions.