Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jul 13, 2023

We need to follow the /sys/module/snd_sof_pci/parameters/fw_path flexibility to test the firmware as whole /lib/firmware package and to stop copying files into /etc/sof/

@marc-hb marc-hb requested a review from keqiaozhang July 13, 2023 01:14
…ameters/fw_path

We need to follow the /sys/module/snd_sof_pci/parameters/fw_path
flexibility to test the firmware as whole /lib/firmware package and to
stop copying files into /etc/sof/

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review July 13, 2023 04:32
@marc-hb marc-hb requested a review from a team as a code owner July 13, 2023 04:32
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 13, 2023

@keqiaozhang
Copy link
Contributor

I checked this PR with my #1065 , sof-logger check passed on all CAVS platforms. But it failed on MTL platforms. please check:
https://sof-ci.ostc.intel.com/#/result/planresultdetail/29116

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 18, 2023

But it failed on MTL platforms. please check:
https://sof-ci.ostc.intel.com/#/result/planresultdetail/29116

That's a totally different bug, unrelated to this PR. Try with this:

--- a/test-case/check-sof-logger.sh
+++ b/test-case/check-sof-logger.sh
@@ -144,7 +144,7 @@ run_loggers()
 
             loggerStatus=0; wait "$mtracetoolPID" || loggerStatus=$?
             test "$loggerStatus" -eq 124 || {
-                cat "$error_file"
+                cat "$etrace_file"
                 die "timeout $mtracetool returned unexpected: $loggerStatus"
             }
         else

@marc-hb marc-hb requested a review from ujfalusi July 18, 2023 08:46
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 18, 2023

That's a totally different bug, unrelated to this PR. Try with this:

Unrelated one-line fix submitted in

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 19, 2023

#1086 merged, @keqiaozhang could you try again?

@keqiaozhang
Copy link
Contributor

#1086 merged, @keqiaozhang could you try again?

sof-logger check still failed on MTL and TGL-H:https://sof-ci.ostc.intel.com/#/result/planresultdetail/29206

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 19, 2023

sof-logger check still failed on MTL and TGL-H:https://sof-ci.ostc.intel.com/#/result/planresultdetail/29206

Yes but now it's showing the real mtrace problem which means we should merge this sof-test PR and finally enable that test on MTL PR testing :-)

Traceback (most recent call last):
  File "/usr/local/bin/mtrace-reader.py", line 20, in 
    fd = os.open(MTRACE_FILE, os.O_RDONLY)
FileNotFoundError: [Errno 2] No such file or directory: '/sys/kernel/debug/sof/mtrace/core0'

@marc-hb
Copy link
Collaborator Author

marc-hb commented Aug 21, 2023

SOFCI TEST

@marc-hb
Copy link
Collaborator Author

marc-hb commented Aug 22, 2023

Copy link
Contributor

@keqiaozhang keqiaozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Aug 22, 2023

Thanks @keqiaozhang !

@marc-hb marc-hb merged commit 88b983b into thesofproject:main Aug 22, 2023
@marc-hb marc-hb deleted the get-ldc-subdir branch August 22, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants