-
Notifications
You must be signed in to change notification settings - Fork 59
lib.sh: add get_ldc_subdir() that follows /sys/module/snd_sof_pci/parameters/fw_path #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ameters/fw_path We need to follow the /sys/module/snd_sof_pci/parameters/fw_path flexibility to test the firmware as whole /lib/firmware package and to stop copying files into /etc/sof/ Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
https://sof-ci.01.org/softestpr/PR1084/build606/devicetest/index.html has 2 suspend/resume failures, https://sof-ci.01.org/softestpr/PR1084/build607/devicetest/index.html has 1. https://sof-ci.01.org/softestpr/PR1084/build605/devicetest/index.html is amazingly all green. |
|
I checked this PR with my #1065 , sof-logger check passed on all CAVS platforms. But it failed on MTL platforms. please check: |
That's a totally different bug, unrelated to this PR. Try with this: --- a/test-case/check-sof-logger.sh
+++ b/test-case/check-sof-logger.sh
@@ -144,7 +144,7 @@ run_loggers()
loggerStatus=0; wait "$mtracetoolPID" || loggerStatus=$?
test "$loggerStatus" -eq 124 || {
- cat "$error_file"
+ cat "$etrace_file"
die "timeout $mtracetool returned unexpected: $loggerStatus"
}
else |
Unrelated one-line fix submitted in |
|
#1086 merged, @keqiaozhang could you try again? |
sof-logger check still failed on MTL and TGL-H:https://sof-ci.ostc.intel.com/#/result/planresultdetail/29206 |
Yes but now it's showing the real mtrace problem which means we should merge this sof-test PR and finally enable that test on MTL PR testing :-) |
|
SOFCI TEST |
|
Just one unrelated pause/resume failure in https://sof-ci.01.org/softestpr/PR1084/build645/devicetest/index.html Just one well known and unrelated UP2 topology issue in https://sof-ci.01.org/softestpr/PR1084/build644/devicetest/index.html?model=APL_UP2_NOCODEC&testcase=verify-tplg-binary Everything else including ACE https://sof-ci.01.org/softestpr/PR1084/build646/devicetest/index.html is green. |
keqiaozhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
|
Thanks @keqiaozhang ! |
We need to follow the
/sys/module/snd_sof_pci/parameters/fw_pathflexibility to test the firmware as whole /lib/firmware package and to stop copying files into /etc/sof/