volume-basic-test.sh: catch amixer failures and log all controls #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for thesofproject#312 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This (1) provides some logging (2) avoids skip_test if amixer fails Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR1074/build531/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1074/build532/devicetest/index.html have only suspend/resume failures. Just 1 suspend/resume failure in https://sof-ci.01.org/softestpr/PR1074/build530/devicetest/index.html The test is still SKIP in https://sof-ci.01.org/softestpr/PR1074/build530/devicetest/index.html?model=TGLU_RVP_NOCODEC_IPC4ZPH&testcase=volume-basic-test but thanks to this PR now we can see why and make sure amixer did not fail |
Collaborator
Author
|
This is the more "cosmetic" subset of #1068 which requires more discussion - while this one can hopefully be expedited. |
keqiaozhang
approved these changes
Jul 4, 2023
Contributor
keqiaozhang
left a comment
keqiaozhang
left a comment
There was a problem hiding this comment.
A very small change and can catch the corner case when amixer fails. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (1) provides some logging (2) avoids
skip_testif amixer fails