check_alsabat.sh: add format support #1009
Conversation
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
This PR is hiding a backwards-incompatible change. I understand you did that to align with alsabat which is good but it will break existing users. This should at the very least be explained in a separate commit message, clearly visible in the git log.
- commit 1: rename -f[requency] option to -F for alsabat consistency
- commit 2: add new -f[format] option
With the NEW code, what happens when someone does check-alsabat.sh -f 821? Do they get a meaningful error message from alsabat? Add that error message in the first commit message.
test-case/check-alsabat.sh
Outdated
|
|
||
| OPT_NAME['r']='rate' OPT_DESC['r']='sample rate' | ||
| OPT_HAS_ARG['r']=1 OPT_VAL['r']=48000 | ||
| OPT_HAS_ARG['r']=1 OPT_VAL['r']=48000 |
There was a problem hiding this comment.
This is pure git noise, don't.
https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes
keqiaozhang
force-pushed
the
alsa_format
branch
2 times, most recently
from
482481b to
3783bca
Compare
|
Please help to review. If no objections, I will merge this PR myself, because I also need to update the parameters(
|
| OPT_NAME['f']='format' OPT_DESC['f']='target format' | ||
| OPT_HAS_ARG['f']=1 OPT_VAL['f']="S16_LE" | ||
|
|
||
| OPT_NAME['F']='frequency' OPT_DESC['F']='target frequency' | ||
| OPT_HAS_ARG['F']=1 OPT_VAL['F']=821 |
There was a problem hiding this comment.
Will the change of -f break the backward compatibility? For example, daily MTL test runs for different frequencies with -f.
There was a problem hiding this comment.
Yes, so we need to update the alsabat test config in web accordingly when merging this PR.
|
Very small conflict with #991 that I just merged, need to rebase sorry. One model missing and some suspend/resume failures in https://sof-ci.01.org/softestpr/PR1009/build173/devicetest/index.html https://sof-ci.01.org/softestpr/PR1009/build174/devicetest/index.html all green. |
…tency Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
add a new option -f to support different formats in alsabat test. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
keqiaozhang
force-pushed
the
alsa_format
branch
from
3783bca to
53328bf
Compare
|
@marc-hb , rebased. Please give a check again. if no problems, I will merge it today. |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Please make sure the test results are OK-ish.
4 participants
add a -f option to support audio format.