v2.11.x: fixup the intel-signed/sof-arl.ri link #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the symbolic link to explicitly link intel-signed/sof-arl.ri to the intel-signed/sof-mtl.ri binary. This is first such symbolic link for a intel-signed image, so better to set a clean first example as this approach is likely to be copied to handle other similar cases. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
ujfalusi
approved these changes
Nov 5, 2024
| @@ -1 +1 @@ | |||
| ../../mtl/sof-mtl.ri No newline at end of file | |||
| ../../mtl/intel-signed/sof-mtl.ri No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
../../mtl/sof-mtl.ri is pointing to ../../mtl/intel-signed/sof-mtl.ri, right?
Collaborator
Author
There was a problem hiding this comment.
@ujfalusi ack, no functional difference, but just looking at convention, we already have communty/sof-foo.ri pointing to community/sof-bar.ri in case same binaries can be used, so to keep consistency, we should do the same for intel-signed/sof-foo.ri.
bardliao
approved these changes
Nov 5, 2024
|
This helped me on Lenovo T16. |
Collaborator
Author
|
@PetrGlad We've done two major releases (2025.01 and 2025.05) upstream, so this fix should be in most Linux distros by now. https://github.com/thesofproject/sof-bin/releases |
|
@kv2019i It is not in stable Pop!_OS yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the symbolic link to explicitly link intel-signed/sof-arl.ri to the intel-signed/sof-mtl.ri binary.
This is first such symbolic link for a intel-signed image, so better to set a clean first example as this approach is likely to be copied to handle other similar cases.