[SKIP SOFCI-TEST] validate no alsa docker for PR#9870 [DNM] #9968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgturner1
changed the title
cgturner1
force-pushed
the
alsa-less-test
branch
from
a6d64c7 to
2a8c10a
Compare
cgturner1
force-pushed
the
alsa-less-test
branch
3 times, most recently
from
b03905e to
517dacc
Compare
cgturner1
force-pushed
the
alsa-less-test
branch
2 times, most recently
from
256aab9 to
01ff653
Compare
kv2019i
reviewed
Apr 23, 2025
| continue-on-error: true | ||
| run: CMAKE_BUILD_TYPE=Release ./scripts/docker-run.sh | ||
| ./scripts/build-tools.sh -Y -A || | ||
| ./scripts/build-tools.sh -A -Y || |
Collaborator
There was a problem hiding this comment.
@cgturner1 Right, so with this workflow, the workspace layout is different (than with zephyr.yml checkous), so the topologu cmake rules won't find the built alsa tools, and you get an error about "unknown target 'topologies1'"
But, but, I guess the easy fix is to remove docker-run.sh from here (L51) altogether. Now that we don't need the alsa tools from docker, we should just be able to run build-tools.sh directly in the Ubuntu environment.
cgturner1
force-pushed
the
alsa-less-test
branch
4 times, most recently
from
72c54dd to
4d7c996
Compare
Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
Introduces the SOF_WORKSPACE environment variable to specify the workspace path, ensuring consistent environment configuration for the Docker container. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
cgturner1
force-pushed
the
alsa-less-test
branch
2 times, most recently
from
833a98b to
110376e
Compare
Replaces the generic 'latest' tag with a specific versioned Docker tag '20250505_ubuntu22.04' to ensure build consistency and reproducibility. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
Ensures the created user has group write permissions by adding them to the 'sof' group. This facilitates proper access control during builds requiring shared group access. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
Updates user creation to specify a fixed home directory at /home/sof. Ensures consistency in user home directories for better organization. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to validate docker behavior in PR #9870
Signed-off-by: Christopher Turner christopher.g.turner@intel.com