Switch to NXP PDM MICFIL Zephyr native driver on i.MX8MP #9824
Conversation
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
This pulls in NXP PDM MICFIL drivers changes from Zephyr: aaa119d757294 dts: xtensa: nxp_imx8m: Add PDM MICFIL node 715fbd1f81ced drivers: dai: Add initial support for NXP MICFIL PDM IP Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
force-pushed
the
enable_micfil
branch
from
dedfa62 to
e9a43a5
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, I would just add a comment (to make it easier later on when we remove legacy)
| case SOF_DAI_IMX_MICFIL: | ||
| channel = dai_get_handshake(dd->dai, dai->direction, | ||
| dd->stream_id); | ||
| #ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS |
There was a problem hiding this comment.
Would be nice to have an inline comment here stating why this is needed.
Support PDM MICFIL interface with Zephyr native driver interface. SOF PDM MICFIL driver is no longer supported and it will be soon removed. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
With Zephyr native driver we use timer domain. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Enable PDM MICFIL dts node and config option. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
force-pushed
the
enable_micfil
branch
from
e9a43a5 to
e521c75
Compare
|
Changes since v2:
|
|
@lgirdwood @lyakh care to look at intel tests failing? are they caused by the west.yml update? |
Results look as expected. @lyakh pls review. |
|
Merge was done while I was still writing this, but I'll submit anyways. Most of the Intel fails seem unrelated to the PR, but not 100% sure about this: It's a DSP panic on LNL I don't recall seeing with SOF main. Not much in the logs. Could be good/bad luck hitting a rare bug or an issue triggered by the Zephyr baseline update (it's been a full month and ~2000 commits since last update). We'll soon see whether this starts to pop up in other PRs. |
3 participants
This is the last part of switching from SOF driver to Zephyr native drivers for NXP platforms. After this gets merged in we will do cleanup for SOF drivers and remove them.