topology2: intel: fix default BT clock for ACE1.5 and newer #9809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bluetooth configurations use the 24.576Mhz Cardinal Clock as clock source for ACE1.5, configured via the new "clock_source" parameter. Set BT_MCLK correctly for these platforms. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add a comment that "clock_source" link configuration must be compatible with BT_MCLK. The current generic definition hard codes BT clock source to 1. This definition is ignored on older platforms, and on newer platforms it maps to same 24.576Mhz Cardinal Clock. This sets different constraints on BT_MCLK depending on the target platform. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Fix stray bad indentation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
ujfalusi
approved these changes
Feb 4, 2025
Collaborator
Author
|
@udaymb can you check this as well? -> this was done |
lgirdwood
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in clock definitions for BT offload configurations. The BT_MCLK and link_control.clock_source definitions must match and this has not been the case for all ACE1.5+ scenarios.
The practical impacts are limited as this does not impact the common HFP NB/WB configuration, as the DSP is not the clock provider in these cases.
Impacts can be seen on ACE1.5+ with A2DP offload and BT HFP LBM test mode. Result is incorrect playback/capture speed.