lib: dai: Fix dai_get_device #9807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
LaurentiuM1234
approved these changes
Feb 3, 2025
dai_get_device is called using DAI-types from IPC definition but calls dai_config_get() which returns a Zephyr DAI type. So, in order to fix this, we introduce `dai_type_to_zephyr` which converts a DAI-type from IPC definition to a Zephyr DAI type, so that later we can compare types in the same space. The current code works because the two DAI types are matching, but it is no longer the case with latest introduces types. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
LaurentiuM1234
approved these changes
Feb 4, 2025
Collaborator
Author
|
v2
|
iuliana-prodan
approved these changes
Feb 4, 2025
kv2019i
approved these changes
Feb 4, 2025
Collaborator
|
FYI @thesofproject/amd @thesofproject/mediatek this may impact your work with SOF Zephyr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dai_get_device is called using DAI-types from IPC definition but calls dai_config_get() which returnes a Zephyr DAI type.
So, in order to fix this, we introduce
dai_type_to_zephyrwhich converts a DAI-type from IPC definition to a Zephyr DAI type, so that later we can compare types in the same space.The current code works because the two DAI types are matching, but it is no longer the case with latest introduces types.
Fixes: #9803