ipc4: base_fw: Return an empty list for inactive cores #9581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior expected by the driver on the host is that if the IPC `IPC4_SCHEDULERS_INFO_GET` is sent for an inactive core, the FW will return success with an empty list in the payload. This patch addresses these shortcomings in the implementation by adding the appropriate IF statement and initializing an empty list regardless of whether something will be added to it later. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
tmleman
requested review from
abonislawski,
dnikodem,
gbernatxintel,
marcinszkudlinski,
serhiy-katsyuba-intel and
softwarecki
lyakh
approved these changes
Oct 16, 2024
serhiy-katsyuba-intel
approved these changes
Oct 16, 2024
dnikodem
approved these changes
Oct 16, 2024
lgirdwood
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior expected by the driver on the host is that if the IPC
IPC4_SCHEDULERS_INFO_GETis sent for an inactive core, the FW will return success with an empty list in the payload.This patch addresses these shortcomings in the implementation by adding the appropriate IF statement and initializing an empty list regardless of whether something will be added to it later.