ipc4: remove unused code #9574
Merged
ipc4: remove unused code #9574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
serhiy-katsyuba-intel
force-pushed
the
unused_func
branch
from
56c91da to
6a0af3a
Compare
serhiy-katsyuba-intel
changed the title
abonislawski
approved these changes
Oct 14, 2024
dnikodem
approved these changes
Oct 14, 2024
tmleman
approved these changes
Oct 14, 2024
lyakh
approved these changes
Oct 15, 2024
lgirdwood
approved these changes
Oct 15, 2024
Member
Removes unused process_dma_index() from src/ipc/ipc4/helper.c. In addition to being unused, that func also requires all IPC4 platforms to define PLATFORM_MAX_DMA_CHAN. On some platforms that unused func is the only place such define is used. Removing the unused func allows to skip defining of PLATFORM_MAX_DMA_CHAN on platforms where it is not needed. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
force-pushed
the
unused_func
branch
from
6a0af3a to
453a142
Compare
Contributor
Author
|
The error reported by Internal Intel CI looks like some infrastructure problem: Re-trigered CI to check again. |
|
@lgirdwood good to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused process_dma_index() from src/ipc/ipc4/helper.c.
In addition to being unused, that func also requires all IPC4 platforms to define PLATFORM_MAX_DMA_CHAN. On some platforms that unused func is the only place such define is used. Removing the unused func allows to skip defining of PLATFORM_MAX_DMA_CHAN on platforms where it is not needed.