Skip to content

Conversation

@charleskeepax
Copy link
Contributor

Add support for a Lenovo SKU that uses cs42l43 and the host side DMICs rather than the CODECs DMICs.

Not done much with host side DMICs before and I don't have hardware to test this so please review carefully and please reach out to me on email if we need to discuss anything.

kv2019i
kv2019i previously approved these changes Oct 8, 2024
"cavs-sdw\;sof-lnl-cs42l43-l0-cs35l56-l3-2ch\;PLATFORM=lnl,\
NUM_DMICS=2,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,\
NUM_SDW_AMP_LINKS=1,SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,\
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need nhlt support when host DMIC is used. PREPROCESS_PLUGINS=nhlt,NHLT_BIN=sof-lnl-cs42l43-l0-cs35l56-l3-2ch.bin. Also, the machine driver will always create two dmic links "dmic01" and "dmic16k". So, I assume the HDMI link id will be 6, 7, and 8. HDMI1_ID=6,HDMI2_ID=7,HDMI3_ID=8.
#9550 could be a reference.

@kv2019i kv2019i dismissed their stale review October 9, 2024 13:50

Missed the NHLT need.

Add support for a Lenovo SKU that uses cs42l43 and the host side DMICs
rather than the CODECs DMICs.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
@bardliao bardliao merged commit 5dcc7c8 into thesofproject:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants