Enable Copier Gain feature for DMIC interface #9537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define common IPC4 Dmic blob structures Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
iganakov
requested review from
RanderWang,
abonislawski,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
lgirdwood
reviewed
Oct 2, 2024
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, but can you also explain when/how DMA control IPC is used. Thanks
tlissows
reviewed
Oct 3, 2024
iganakov
force-pushed
the
iganakov/dmic_enable_gain
branch
from
60f3a5d to
9babc61
Compare
kv2019i
reviewed
Oct 3, 2024
| dai.out_fmt = &copier->out_fmt; | ||
| #if CONFIG_COPIER_GAIN | ||
| dai.apply_gain = true; | ||
| #endif |
Collaborator
There was a problem hiding this comment.
What happens when no configuration is passed from the host (like in case of Linux driver)? Unity gain applied? This seems to be enabled by default.
Contributor
Author
There was a problem hiding this comment.
@kv2019i Yes, unity gain applied (gain = 1)
tlissows
requested changes
Oct 3, 2024
Enable gain for DMIC interface. Configure gain feature with parameters received in DMIC BLOB. Add support for runtime DMIC gain parameters update using DMA Control IPC. Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
iganakov
force-pushed
the
iganakov/dmic_enable_gain
branch
from
9babc61 to
0fd9030
Compare
tlissows
approved these changes
Oct 3, 2024
lgirdwood
approved these changes
Oct 3, 2024
dnikodem
approved these changes
Oct 4, 2024
singalsu
approved these changes
Oct 4, 2024
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Looks OK to me. The dmic structs are same though here more detailed based on updated documentation vs. the other dmic.h. It could be cleaned up later to avoid duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Copier Gain feature, introduced in #9323, to DMIC interface.
Add complete DMIC configuration blob definitions.
Use DMA Control IPC message to update gain coefficients in runtime.