Lib: Add to dai-legacy.h struct copier_gain_params for testbench #9536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new copier gain feature needs this structure. The added member is copied directly from dai-zephyr.h. Testbench IPC4 is using legacy DAI definitions instead of Zephyr DAI to avoid to include a lot of difficult dependencies. Build of testbench fails if dai-legacy.h does not contain this. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The include of dai-zephyr.h causes IPC4 testbench build to fail due to further include of Zephyr headers. Since the copier_generic.c build is not needing it, it can be removed. The HiFi build version copier_hifi.c is already without this include. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
RanderWang,
abonislawski,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
lgirdwood
approved these changes
Oct 2, 2024
kv2019i
approved these changes
Oct 3, 2024
Collaborator
|
Re-ran a few github CI flows, now looks good. Proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches for copier to prevent IPC4 testbench build fail. Copier is part of SOF lib build that is linked to testbench executable. File component is a minimal implementation of a copier and uses copier headers.