Test: Cmocka: Set component type to SOF_COMP_MODULE_ADAPTER #9529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change done in commit b53573a ("ipc3: override type field once comp_driver found") expects the component type via init IPC to be the same as module register sets (SOF_COMP_MODULE_ADAPTER). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Since with module adapter the component type from init IPC is no more SOF_COMP_MUX or SOF_COMP_DEMUX but SOF_COMP_MODULE_ADAPTER, the mux mode check needs to be change. The type is set in init() based on which init function was used. All checks for dev->ipc_config.type are changed to check of cd->comp_type. The set of type in mux_ipc4.c is removed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
dbaluta,
fkwasowi,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
dbaluta
approved these changes
Oct 1, 2024
lgirdwood
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.