buffer: init channels to 2 #9528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On initialization we use rzalloc which 0s out all fields. We later call audio_stream_recalc_align which uses the frame_bytes to align the buffer. This is problematic as clz() is passed the size of the frame size which is 0 since channel is 0 and passing 0 to clz is undefined behaviour. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
dbaluta
approved these changes
Oct 1, 2024
lgirdwood
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On initialization we use rzalloc which 0s out all fields. We later call audio_stream_recalc_align which uses the frame_bytes to align the buffer. This is problematic as clz() is passed the size of the frame size which is 0 since channel is 0 and passing 0 to clz is undefined behaviour.