Fuzzer cleanup #9527
Merged
Fuzzer cleanup #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cujomalainey
commented
Sep 30, 2024
cujomalainey
commented
- Delete old fuzzer code
- Fix overflow in posix fuzzers
All fuzzing infra has moved to the posix platform. The corpus is not being deployed, and is soon to be modified anyways. Its also missing IPC4 in the corpus. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
requested review from
a team,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Oct 1, 2024
Member
|
@ranj063 pls review. |
andyross
approved these changes
Oct 1, 2024
Contributor
andyross
left a comment
andyross
left a comment
There was a problem hiding this comment.
Whine about verbosity, but looks good here
Fix silent overflow in the fuzzer. 255 is clearly << 65536 so that means we are not able to exercise the full buffer. But upon further inspection its clear that numbers are a minimum truncated if not rolling over based on the code in the size_t to uint8_t conversions. This was validated by converting the type temporarily to signed and observing the fuzzer using a negative index. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
kv2019i
approved these changes
Oct 2, 2024
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Ready to go once CI runs complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.