ipc4: base_fw: Consistently use IPC4 status codes #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
Author
|
The changes address the problems from issue #5737 |
tmleman
requested review from
abonislawski,
dnikodem,
iganakov,
lyakh,
marcinszkudlinski and
softwarecki
This patch addresses the issue of inconsistent error code usage in the base_fw.c file, where a mix of POSIX and IPC4 error codes was previously present. The IPC4 error codes are now used consistently throughout the file, ensuring that the error handling is aligned with the IPC4 protocol expectations. The changes include replacing POSIX error codes such as 0, -EINVAL, and -ENOMEM with their corresponding IPC4 status codes IPC4_SUCCESS, IPC4_ERROR_INVALID_PARAM, and IPC4_OUT_OF_MEMORY, respectively. This standardization helps to avoid confusion and potential bugs that can arise from the mixed usage of different error code conventions. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
lgirdwood
approved these changes
Oct 1, 2024
iganakov
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the issue of inconsistent error code usage in the base_fw.c file, where a mix of POSIX and IPC4 error codes was previously present.
The IPC4 error codes are now used consistently throughout the file, ensuring that the error handling is aligned with the IPC4 protocol expectations. The changes include replacing POSIX error codes such as 0, -EINVAL, and -ENOMEM with their corresponding IPC4 status codes IPC4_SUCCESS, IPC4_ERROR_INVALID_PARAM, and IPC4_OUT_OF_MEMORY, respectively. This standardization helps to avoid confusion and potential bugs that can arise from the mixed usage of different error code conventions.