rimage: use platform extra flags when signing LLEXT modules #9509
Conversation
The user can configure west to pass additional arguments to rimage for signing, we need to use them when signing LLEXT modules too. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
It should work but will duplicate -k parameter
Before:
rimage -o drc.llext.ri -e -c rimage_config.toml -k otc_private_key_3k.pem -l -r drc.llext
After:
rimage -o drc.llext.ri -e -c rimage_config.toml -k otc_private_key_3k.pem -l -r -k otc_private_key_3k.pem -f 2.10.99 -b 1 drc.llext
@abonislawski yes, a more comprehensive solution could filter parameters to avoid duplicates. If that's more important than a fast solution, we can try adding that. Otherwise you can also just remove the key from your local configuration. But even as is it shouldn't cause issues? |
|
No issues, it doesnt matter for rimage. |
|
@lyakh @abonislawski lets go with this now, clean up the cmd line to avoid duplicates is less urgent today, also scripts that call this can be fixed to do the right thing too. |
4 participants
The user can configure west to pass additional arguments to rimage for signing, we need to use them when signing LLEXT modules too.