Add support for enum controls in the SOF plugin #9474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
requested review from
dbaluta,
jsarha,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Add an index field for kcontrols. This will be useful in differenciating kcontrols of the same type in a widget. Modify the signature of the control callback function to pass the index as an argument when creating kcontrols. Pass 0 for ipc3 kcontrol builds as it will be unused in this case anyway. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Use the ops info to differentiate the different kcontrols in topology. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Use the size of struct ipc4_module_large_config_reply instead of the size of the pointer. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This will avoid the duplicated code when configuring the IPC message for kcontrol IO. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add support for enum controls in the plugin. Fix the get_attribute and get_enumerated_name callbacks to use the enum control items instad of the count. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/plugin_kcontrol
branch
from
6ba3672 to
792f7b0
Compare
lgirdwood
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.