[DNM][DNR] Test windows CI breakage fix #9469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF requires some additions to the Zephyr linker script.
This should be handled inside SOF instead of Zephyr.
Since 3f2790b89ca5 ("soc: imx93: remove custom linker script")
removes the custom linker script from Zephyr, this means
the custom SOF linker sections will have to be handled on SOF
side.
This also includes a Zephyr hash bump to 3f2790b89ca5,
which brings the following (potentially) relevant patches:
3f2790b89ca5 soc: imx93: remove custom linker script
d389c95935c5 soc: intel_adsp: ace: Configurable SRAM
retention mode and cleanup
be041b14fe51 Intel: ADSP: move HPSRAM mask into assembly
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Zephyr commit b3b8360f3993 ("west: runners: Add `west rtt` command
with pyocd implementation") adds some functionality to the
west commands making use of the pipe ("|") operator for
function return type hinting. As per PEP 604 [1], this operator
can be used for writing union types starting from python 3.10.
Since the SOF windows builds use python 3.8 this leads to
the CI failing.
To fix this, switch to using python 3.10. This is not a
problem for Linux CI jobs as they already use python 3.10.
The following is a snippet of a failed windows CI job
regarding this:
File "D:\a\sof\sof\workspace\zephyr\scripts/west_commands\runners\core.py",
line 780, in ZephyrBinaryRunner
def get_rtt_address(self) -> int | None:
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
[1]: https://peps.python.org/pep-0604/
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of #9468, which is the fix + #9372 which exposes the issue.