platform/xtos: remove shim.h interface as it's no longer needed #9461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only remaining user of the SOF shim.h platform interface is Intel Tiger Lake platform. And even for this target, only a very small part of the interface is used. Everything else is either not used, and/or moved to Zephyr. Move the remaining definitions to the Tiger Lake implementation, allowing the interface to be removed from SOF platform layer. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Only native Zephyr drivers supported now for Intel cAVS, so dw-dma.h can be removed. Removing this file allow to remove the SOF shim.h layer. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Memory management has been moved to Zephyr for these platforms, so this file can be removed. Removing this file allow to remove the SOF shim.h layer. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Memory power management has been moved to Zephyr for these platforms, so this file can be removed. Removing this file allow to remove the SOF shim.h layer. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
All users of shim.h have been either removed and/or moved to Zephyr, so the interface can be removed from codebase. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Remove the shim.h interface from RTOS layer as there is no use of this interface anymore in SOF codebase. Link: thesofproject#9015 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Fix errors in code documentation to match the implementation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
lbetlej,
lgirdwood,
lyakh,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Sep 11, 2024
lyakh
approved these changes
Sep 12, 2024
tmleman
approved these changes
Sep 12, 2024
39 tasks
Collaborator
Author
|
Seems to have hit error in test execution on TGL DUT, but failure seems to be related to getting the test to run "TestLoadFwBasic --platform*TGL' is failed: Test did not even start". @wszypelt can you check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series of patches to remove remaining usage of shim.h interface and finally remove the whole interface both from platform and xtos layers.
Link: #9015