LLEXT: automatically calculate module addresses (first part of #9430) #9439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
CI: IIUC https://sof-ci.01.org/sofpr/PR9439/build7624/devicetest/index.html unrelated, https://sof-ci.01.org/sofpr/PR9439/build7626/devicetest/index.html - one device missing |
lyakh
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
Collaborator
Author
|
Since we decided to split #9430 and since this passes tests, let's merge it |
kv2019i
approved these changes
Sep 5, 2024
lyakh
changed the title
lgirdwood
approved these changes
Sep 9, 2024
Member
|
@lyakh can you give it a quick fixup for the conflict. Thanks |
Add a Kconfig option that can be used to flip all LLEXT-supporting code to a modular build. Use that global flag for smart-amp-test, mixin-mixout and eq-iir. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Currently LLEXT module starting addresses are hard-coded in their respective CMakeLists.txt files. This is very wasteful, since it's unknown in what order modules are loaded, inflexible and not easily extendible to other platforms. Switch to calculating addresses automatically based on a single per-platform Kconfig value. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
LNL modules overlay is missing eq_iir and mixin_mixout entries, add them there. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
pr-build seems stuck, restarting |
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
CI: unrelated LNL failures https://sof-ci.01.org/sofpr/PR9439/build7780/devicetest/index.html |
Member
|
Are we now unable to set module address to IMR for one module and HPSRAM for another? |
Collaborator
Author
@abonislawski with this - no, with this module addresses are calculated automatically. Running in IMR needs to be added separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important change here is an automatic module address calculation, simplifies modularisation a lot.