iadk: Define pass buffer size and return error code from entry point function #9424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
abonislawski,
gbernatxintel,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
serhiy-katsyuba-intel,
tmleman and
tobonex
softwarecki
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
lyakh
reviewed
Sep 2, 2024
lgirdwood
reviewed
Sep 2, 2024
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, just need to add the new macro to the IADK namespace
softwarecki
force-pushed
the
iadk-handle
branch
2 times, most recently
from
f74c888 to
c288670
Compare
lgirdwood
approved these changes
Sep 11, 2024
tobonex
approved these changes
Sep 11, 2024
serhiy-katsyuba-intel
approved these changes
Sep 11, 2024
tmleman
approved these changes
Sep 12, 2024
kv2019i
reviewed
Sep 12, 2024
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @softwarecki , especially the module load description is a nice addition!
One question, can you check.
lyakh
reviewed
Sep 12, 2024
Add a definition specifying the size of space reserved in module memory for module handle and a iadk adapter. Add a brief description of the iadk module loading sequence. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Change the definition of the system_agent_start function so that it returns the error code returned by the module's entry point functions. Return the created IadkModuleAdapter object via a parameter. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
iadk-handle
branch
from
c288670 to
fab7cab
Compare
lyakh
reviewed
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a definition specifying the size of space reserved in module memory for module handle and a iadk adapter.
Add a brief description of the iadk module loading sequence.
Change the definition of the system_agent_start function so that it returns the error code returned by the module's entry point functions. Return the created IadkModuleAdapter object via a parameter.