Eradicate -Wl,-EL for good #9353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As already discussed in commit bcbcec7 ("cmake: drop binutils-specific '-Wl,-EL' option") and commit ee58fef ("smex/cmake: move -Wl,EL option to target_linker_options() for clang") and their corresponding reviews on GitHub, this binutils-specific, endianness option makes no difference and is causing clang compatibility issues. It's now getting in the way of thesofproject#9351 "Add the new platform ACP_7_0". I ran `./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a` with and without it and there was absolutely zero binary difference. I was added in 2019 by giant commit e0ba98d ("cmake: add CMakeLists for firmware build") without any rationale of why it would be needed. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This option was added by initial commit 36929ae ("smex: Create new tool to build ldc file") without any justification. It has been causing countless portability issues, see previous commit for examples. It makes even less sense for a build-time utility. Get rid of it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This mysterious option has been causing portability issues and has never made any difference, see previous commits for details. I compiled the plugin with and without it and there was absolutely zero binary difference. Let's remove it from all tools/plugin/ CMakeLists.txt files before the mass copy/paste/diverge there spreads it even more. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
One model missing in https://sof-ci.01.org/sofpr/PR9353/build6922/devicetest/index.html, everything else green. Known LNL issues in https://sof-ci.01.org/sofpr/PR9353/build6920/devicetest/index.html MTL https://sof-ci.01.org/sofpr/PR9353/build6921/devicetest/index.html all green. |
marc-hb
requested review from
abonislawski,
andyross,
dcpleung,
softwarecki and
tmleman
tmleman
approved these changes
Aug 8, 2024
kv2019i
approved these changes
Aug 8, 2024
saisurya-ch
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered while reviewing #9351
See commit messages for details.
It's 2024 and copy/paste/diverge still rulez :-(