Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jul 18, 2024

Temporarily disable CONFIG_MODULES to get MTL working again.

Avoids crash #9308

Temporarily disable CONFIG_MODULES to get MTL working again.

Avoids crash thesofproject#9308

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review July 18, 2024 17:38
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 18, 2024

MTL https://sof-ci.01.org/sofpr/PR9313/build6572/devicetest/index.html is not finished yet but I looked at it on the internal site and everything is 100% green so far.

This one-line CONFIG_ change moves us from "NOTHING works on MTL" back to "everything works on MTL". This is NOT an actual fix #9308 but this restores project velocity while not even reverting a single line of actual code.

This does not even lose much LLEXT coverage because LNL is still being tested with LLEXT!
https://sof-ci.01.org/sofpr/PR9313/build6570/build/firmware_community/lnl.log

I don't think there can be any least intrusive way to get MTL CI back up and running and things moving again.

EDIT: kudos to @fredoh9 for leading me to this minimal solution: #9308 (comment)

The 2 pause failures in LNL https://sof-ci.01.org/sofpr/PR9313/build6571/devicetest/index.html are known (thesofproject/linux#5109 and #9123) and unrelated. This PR makes absolutely zero LNL change.

No cavs failure in https://sof-ci.01.org/sofpr/PR9313/build6573/devicetest/index.html, just a model missing.

Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Weird that the resume crash is MTL-specific though

@fredoh9
Copy link
Contributor

fredoh9 commented Jul 18, 2024

Wow, good finding for minimum change. 👍

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 18, 2024

Weird that the resume crash is MTL-specific though

Yes: this seems like a very complex issue. All the relevant PRs passed in isolation, see details in #9308. I think this shows that bug is complex and unlikely to be root-caused and fixed in a short time.

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. I don't think we have a choice, we need to get CI back functional and this is a minimal change. Some tests still running, but so far lal looks good. Please @lyakh and @tmleman follow up to the PR to reenable CONFIG_MODULES when fix is found.

@kv2019i kv2019i merged commit 8847de0 into thesofproject:main Jul 18, 2024
@marc-hb marc-hb deleted the mtl-modules-hotfix branch July 18, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants