Skip to content

Conversation

@plbossart
Copy link
Member

Start moving SoundWire topologies from the shadows into main...

@plbossart
Copy link
Member Author

plbossart commented Jul 16, 2024

@bardliao @fredoh9 any idea how to create sof-ptl-rt722-l3 ?

@fredoh9
Copy link
Contributor

fredoh9 commented Jul 16, 2024

@bardliao built and generated it, I was able to test it on the FPGA.

DMIC_DRIVER_VERSION 5
SSP_BLOB_VERSION 0x300
NUM_HDMIS 3
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated in #9306, just a heads up.
cc: @singalsu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, same definitions to enable build of PR. Rebase will fix this whichever PR is merged first.

IncludeByKey.PLATFORM {
"mtl" "platform/intel/mtl.conf"
"lnl" "platform/intel/lnl.conf"
"ptl" "platform/intel/ptl.conf"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a dumb question sorry: why is this file called CAVS-sdw.conf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we started using it on cavs... it's meaningless, only the sdw part matters.

@bardliao
Copy link
Collaborator

@bardliao @fredoh9 any idea how to create sof-ptl-rt722-l3 ?

I believe that rt722-l3 can use the same topology as rt722-l0. We use partial match to match the stream name and do not include the link information. I.e. SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack

@plbossart
Copy link
Member Author

then why do we have different topology names in the kernel? We could just as well use sof-ptl-rt722.tplg in all ACPI tables where RT722 is used.

Start moving SoundWire topologies from the shadows into main...

We generate a single topology for RT722-based skews since the link
information is not used in the matching with the machine driver
dailinks. The same topology can be used for link0 or link3 setups.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart force-pushed the topology/ptl-rt722 branch from 3416fa2 to 8c7b744 Compare July 17, 2024 09:45
@plbossart
Copy link
Member Author

v2: used a single topology name. The matching kernel change is here: thesofproject/linux#5111

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 17, 2024

SOFCI TEST

@plbossart plbossart requested review from singalsu and ujfalusi July 18, 2024 08:32
@plbossart plbossart marked this pull request as ready for review July 18, 2024 08:33
@plbossart plbossart requested review from jsarha and ranj063 as code owners July 18, 2024 08:33
# Array of "input-file-name;output-file-name;comma separated pre-processor variables"
list(APPEND TPLGS
# SDW topology for PTL RVP
"cavs-sdw\;sof-ptl-rt722\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has dependency on thesofproject/linux#5111 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it's even described above :-)

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 18, 2024

SOFCI TEST

@lgirdwood lgirdwood merged commit dc28dbd into thesofproject:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants