-
Notifications
You must be signed in to change notification settings - Fork 349
topology2: add basic definitions for PTL #9305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bardliao built and generated it, I was able to test it on the FPGA. |
| DMIC_DRIVER_VERSION 5 | ||
| SSP_BLOB_VERSION 0x300 | ||
| NUM_HDMIS 3 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, same definitions to enable build of PR. Rebase will fix this whichever PR is merged first.
| IncludeByKey.PLATFORM { | ||
| "mtl" "platform/intel/mtl.conf" | ||
| "lnl" "platform/intel/lnl.conf" | ||
| "ptl" "platform/intel/ptl.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a dumb question sorry: why is this file called CAVS-sdw.conf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we started using it on cavs... it's meaningless, only the sdw part matters.
I believe that rt722-l3 can use the same topology as rt722-l0. We use partial match to match the stream name and do not include the link information. I.e. |
|
then why do we have different topology names in the kernel? We could just as well use sof-ptl-rt722.tplg in all ACPI tables where RT722 is used. |
Start moving SoundWire topologies from the shadows into main... We generate a single topology for RT722-based skews since the link information is not used in the matching with the machine driver dailinks. The same topology can be used for link0 or link3 setups. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
3416fa2 to
8c7b744
Compare
|
v2: used a single topology name. The matching kernel change is here: thesofproject/linux#5111 |
|
SOFCI TEST |
| # Array of "input-file-name;output-file-name;comma separated pre-processor variables" | ||
| list(APPEND TPLGS | ||
| # SDW topology for PTL RVP | ||
| "cavs-sdw\;sof-ptl-rt722\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has dependency on thesofproject/linux#5111 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, it's even described above :-)
|
SOFCI TEST |
Start moving SoundWire topologies from the shadows into main...