Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jun 26, 2024

Passing options one by one in .github/workflows/zephyr.yml was becoming
unwieldy. Reduces Windows/Linux duplication. This also makes local
testing easier; less typing and guess work.

This should also help with #9116.

marc-hb added 2 commits June 26, 2024 21:44
OVERLAY_CONFIG has been deprecated by EXTRA_CONF_FILE since Zephyr 3.4

Also fix the corresponding --help string.

Zephyr 3.4 is one year old and has just been end-of-lifed.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Passing options one by one in .github/workflows/zephyr.yml was becoming
unwieldy. Reduces Windows/Linux duplication. This also makes local
testing easier; less typing and guess work.

This should also help with thesofproject#9116.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 26, 2024

@andyross can you please help fix these (totally unrelated) sparse warning?

/zep_workspace/sof/src/audio/google/google_rtc_audio_processing.c:529:76: warning: incorrect type in argument 1 (different address spaces)
/zep_workspace/sof/src/audio/google/google_rtc_audio_processing.c:557:40: warning: incorrect type in assignment (different address spaces)
/zep_workspace/sof/src/audio/google/google_rtc_audio_processing.c:558:39: warning: incorrect type in assignment (different address spaces)
/zep_workspace/sof/src/audio/google/google_rtc_audio_processing.c:807:17: warning: incorrect type in argument 1 (different address spaces)

git blame points at you but this code isn't new; so I don't know why this just showed up recently. Someone changed some CONFIG_ somewhere?

Last passing daily test: https://github.com/thesofproject/sof/actions/runs/9606358628

First failing daily test 5 days ago: https://github.com/thesofproject/sof/actions/runs/9621445375

cc: @eddy1021

@andyross
Copy link
Contributor

@andyross can you please help fix these (totally unrelated) sparse warning?

Looking right now. Are there docs on running sparse locally?

FWIW that code did change: it used to be getting the big block from the heap (where it would have been returned as a cached pointer) and now it's doing the conversion itself from a static pointer into .data, which is uncached. Never thought about the sparse interaction until this error showed up, but it's likely real enough and needs an appropriate cast/whitelist/whatever.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 27, 2024

Looking right now. Are there docs on running sparse locally?

Better than documentation: the specific command can be found in .github/workflows/sparse-zephyr.yml. No CI secret for this one!

As you submitted fixup #9265, I assume you already found it.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Jun 27, 2024

A single "updownmixer" test failed in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9264/build14068938, all other tests passed so this PR is clearly not to blame.

EDIT: for some unknown reason this was re-run and https://sof-ci.01.org/sof-pr-viewer/#/build/PR9264/build14069829 is now green.

Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding: this alone won't be enough to resolve the difference between Windows and Linux SOF builds when using LLEXT as in https://github.com/thesofproject/sof/actions/runs/9550440753/job/26323025134?pr=9116 ?
EDIT: just saw #9116 (comment) - got the idea. Maybe even CONFIG_MODULES=n

@kv2019i kv2019i merged commit 6c9df30 into thesofproject:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants