Tools: Topology2: Use rates instead of rate_min/max in benchmark #9218
Conversation
The rate_min/rate_max is obsolete, should use rates with list of rates to support. Without this change the playback of non-48 kHz content happens with 48 kHz rate with pitch shift effect. Aplay shows only a warning. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
|
@ujfalusi Thanks for help, this change fixed the issue! |
gbernatxintel
left a comment
gbernatxintel
left a comment
There was a problem hiding this comment.
In my opinion, the change is correct, but isn't there an error in the line above?
The format should not be saved
formats “S32_LE,S24_LE,S16_LE”
I didn't know. Is there a difference in using " " or ' ' or something else? |
IIUC the topology compiler will stringify if its missing "" |
|
@singalsu I assume we need for v2.10 ? |
None of these development topologies ends up to binary FW release, so I don't think it's needed. If there's source tarball for release, then it would make sense. How is it? |
ok, not needed. |
5 participants
The rate_min/rate_max is obsolete, should use rates with list of rates to support. Without this change the playback of non-48 kHz content happens with 48 kHz rate with pitch shift effect. Aplay shows only a warning.