Misc mt8xxx-related fixups #9210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 296af86 ("Audio: RTNR: Convert to module API") missed a spot: the "rtnr_printf()" function, which is a logging callback from the vendor library, was still using the comp_rtnr driver struct even though it was no longer initialized. This contained a NULL trace context, which would panic on use. (That would then lead to a fun glitch where the reentrantly-confused trace code would then panic inside the tracing done by the panic handler, clobbering the original trace info and reporting to the kenel that the fault was in panic_dump()). This would have been fine with the stub, which does not call rtnr_print(), only the real library would blow up. Fix is to use the trace context directly, as we don't have a component pointer here. Signed-off-by: Andy Ross <andyross@google.com>
This was OK a few months ago, but something in recent SOF has expanded stack requirements and we now get overflows. Move to 12k stacks when AEC is enabled. Signed-off-by: Andy Ross <andyross@google.com>
Compiler flags used with older xcc compilers still disallow declarations in for() expressions. Signed-off-by: Andy Ross <andyross@google.com>
andyross
requested review from
dbaluta,
kuanhsuncheng,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
yaochunhung
as code owners
cujomalainey
approved these changes
Jun 7, 2024
marcinszkudlinski
approved these changes
Jun 10, 2024
lgirdwood
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes needed for working Mediatek builds