Audio: Improvement of multiband_drc memory allocation error handling. #9177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cujomalainey
left a comment
cujomalainey
left a comment
There was a problem hiding this comment.
I don't see much value to this change currently, will need more convincing before I will sign off
lyakh
reviewed
May 31, 2024
lgirdwood
reviewed
Jun 18, 2024
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@ShriramShastry any update ? It looks like this PR can be simplified based on the review comments. Thanks
Contributor
Author
yes, I'II update it shortly. |
ShriramShastry
force-pushed
the
multiband_drc_enhancements
branch
2 times, most recently
from
1fd88f5 to
2d3f81e
Compare
cujomalainey
suggested changes
Jun 21, 2024
Replaces intermediate variable and redundant comments with a direct call to return multiband_drc_init_coef function. Signed-off-by: Shriram Shastry <malladi.sastry@intel.com>
ShriramShastry
force-pushed
the
multiband_drc_enhancements
branch
2 times, most recently
from
470d047 to
84ccf1b
Compare
cujomalainey
approved these changes
Jun 24, 2024
lyakh
approved these changes
Jun 24, 2024
Collaborator
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
I don't see where this commit replaces "redundant comments"...
lgirdwood
approved these changes
Jun 25, 2024
Member
|
@wszypelt good to merge ? Looks like CI been pending a while. |
Contributor
|
CI is stuck >5d nows and this is isolated to a module not in default topologies, assuming CI is borked and bypassing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check-in improves error handling in the
multiband_drccomponent by enabling error logging and returning-ENOMEMif memory allocation fails. It replaces asserts with conditional checks to detect and log errors during memory copy operations. Finally, it streamlines the return logic inmultiband_drc_setupand propagates theinit_coeferror code.