Audio: Optimize division by speed of sound using fixed-point reciprocal #9160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
SOFCI |
Collaborator
|
Thanks @ShriramShastry , this saves 1.4 MCPS with 4ch beamformer in TGL platform. I'll review this PR later. |
ShriramShastry
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
ShriramShastry
force-pushed
the
shastry_perf_inv_sound_speed_optimization
branch
3 times, most recently
from
09f83ff to
0a29b59
Compare
singalsu
requested changes
Jun 6, 2024
ShriramShastry
force-pushed
the
shastry_perf_inv_sound_speed_optimization
branch
from
0a29b59 to
849bce3
Compare
ShriramShastry
force-pushed
the
shastry_perf_inv_sound_speed_optimization
branch
from
849bce3 to
ef64f75
Compare
singalsu
requested changes
Jun 17, 2024
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
The code works correctly, checked with direction_test.m but need to reject due to mistakes in comments, sorry! Can you please fix. This is a quick approve after done.
ShriramShastry
force-pushed
the
shastry_perf_inv_sound_speed_optimization
branch
from
ef64f75 to
9186364
Compare
singalsu
approved these changes
Jun 17, 2024
Collaborator
|
Ready to merge, pending the mandatory CI to pass. |
This commit optimizes the division by the speed of sound in the `theoretical_time_differences` function. By precomputing the fixed-point reciprocal of the speed of sound, we eliminate the need for a costly division operation in each iteration. Additionally, a redundant 'if' statement is removed from the 'tdfb_direction_copy_emphasis' function, simplifying the code. Signed-off-by: Shriram Shastry <malladi.sastry@intel.com>
ShriramShastry
force-pushed
the
shastry_perf_inv_sound_speed_optimization
branch
from
9186364 to
b39cd56
Compare
lgirdwood
approved these changes
Jun 25, 2024
Member
|
@wszypelt looks like CI has been pending a while. Good to merge ? |
|
@lgirdwood good to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit optimizes the division by the speed of sound in the
theoretical_time_differencesfunction. By precomputing the fixed-point reciprocal of the speed of sound, we eliminate the need for a costly division operation in each iteration.