-
Notifications
You must be signed in to change notification settings - Fork 349
nxp: imx8/imx8x: switch to Zephyr logging #9021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nxp: imx8/imx8x: switch to Zephyr logging #9021
Conversation
|
Same, previously seen disassembly difference in https://github.com/thesofproject/sof/actions/runs/8630426621?pr=9021 already observed in #8863 --- win/build-sof-staging/sof-info/imx8x/zephyr.lst 2024-04-10 19:30:27
+++ lin/build-sof-staging/sof-info/imx8x/zephyr.lst 2024-04-04 09:12:34
@@ -81134,6 +81134,12 @@
92433b10: 833441 l32r a4, 924147e0 <_stext+0x1598> (92413034 <s_lpuartClock>)
92433b13: a03340 addx4 a3, a3, a4
92433b16: 03a8 l32i.n a10, a3, 0
+ * @param name Which clock to enable, see \ref clock_ip_name_t.
+ * @return true for success, false for failure.
+ */
+static inline bool CLOCK_EnableClock(clock_ip_name_t name)
+{
+ return CLOCK_EnableClockExt(name, 0);
92433b18: 31e9 s32i.n a14, a1, 12
92433b1a: 00a0b2 movi a11, 0
92433b1d: ffcfa5 call8 92433818 <CLOCK_EnableClockExt>
I downloaded the files, did some inspection, jogged my memory and searched archives and I think I may have found something... Do you have any
So the inline C code seems correct in both cases, but for some reason the same There's one notable difference here: mcux_ccm_on() is located in Zephyr whereas LPUART_Init() is located in modules/hal/nxp! Which is why I'm suspecting I think the simple reason it is appearing now is because you're now enabling some |
|
Interestingly enough this also seems to happen for 8ULP when we pull in the patch that enables LPUART. Results here: https://github.com/thesofproject/sof/actions/runs/8645734717/job/23703888439?pr=9029. @marc-hb would you mind pasting the diffs for that as well? Can't seem to be able to check it out in the CI job :(. Also, is there any other info in the CI job that may help with debugging this? BTW, appreciate the info! |
I've created new issue #9034 and answered there. |
Switch to using Zephyr logging on imx8 and imx8x to prepare for using native Zephyr drivers. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
f354a9e to
22e6188
Compare
Switch to using Zephyr logging on imx8 and imx8x to prepare for using native Zephyr drivers.
Cherry-picked from #8863