lib_manager: Add lib_manager_get_module_manifest function #8974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
abonislawski,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
pjdobrowolski,
serhiy-katsyuba-intel,
tmleman and
tobonex
softwarecki
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
softwarecki
force-pushed
the
module-manifest
branch
from
e6e73c9 to
94b9976
Compare
4 tasks
pjdobrowolski
approved these changes
Mar 25, 2024
Collaborator
|
Needs a rebase. |
All calls to the ipc4_get_comp_drv function pass the uint32_t value as a parameter, so the type of functions parameter was changed. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Added the lib_manager_get_module_manifest function that returns manifest of selected module based on its id. It was performed in many places and moving it into function simplified the code and increased its readability. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The lib_manager_get_library_module_desc function was renamed to lib_manager_get_library_manifest, which better describes what it do. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
module-manifest
branch
from
94b9976 to
cec215f
Compare
Collaborator
Author
|
SOFCI TEST |
kv2019i
approved these changes
Apr 12, 2024
lgirdwood
approved these changes
Apr 12, 2024
tmleman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the lib_manager_get_module_manifest function that returns manifest of selected module based on its id. It was performed in many places and moving it into function simplified the code and increased its readability.
The lib_manager_get_library_module_desc function was renamed to lib_manager_get_library_manifest, which better describes what it do.
All calls to the ipc4_get_comp_drv function pass the uint32_t value as a parameter, so the type of functions parameter was changed to uint32_t.