copier: Use correct multiplier for latency to bytes calculation #8972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latency value is in number of periods (1ms) while the buffer allocated for the DAI copier is at least 2 periods. This can shoot up the calculated stream_start_offset resulting invalid delay reporting. Use the period size of the DAI copier to correct this error. The kernel reported delay currently (on normal non DeepBuffer PCM): at start: ~302 frames after 20x pause/resume: ~6530 frames With this patch: at start: ~254 frames after 20x pause/resume: ~3600 frames The drift rate is about the same with DeepBuffer. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
kv2019i
approved these changes
Mar 21, 2024
tmleman
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latency value is in number of periods (1ms) while the buffer allocated for the DAI copier is at least 2 periods.
This can shoot up the calculated stream_start_offset resulting invalid delay reporting.
Use the period size of the DAI copier to correct this error.
The kernel reported delay currently (on normal non DeepBuffer PCM): at start: ~302 frames
after 20x pause/resume: ~6530 frames
With this patch:
at start: ~254 frames
after 20x pause/resume: ~3600 frames
The drift rate is about the same with DeepBuffer.