Use new '-DREM=#' prefix to preserve comments in pre-processed .toml #8956
Conversation
Having to find source files to read comments is not convenient. This depends on zephyrproject-rtos/zephyr#67019 which was merged a while ago. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
Really unlucky with this one, I'm tempted to just re-run everything :-) IPC timeout during basic playback in https://sof-ci.01.org/sofpr/PR8956/build3484/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=check-playback-3times This seems to put the system in a bad state and all consecutive tests fail. The (lack of) errors does not ring any bell. @kv2019i maybe? Only one UpDownMixer failure in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8956/build13728143, all other tests are green. This isolated UpDownMixer failure can't possibly be related to this .toml PR. |
|
SOFCI TEST Same IPC timeout and cascade of failures in ACE https://sof-ci.01.org/sofpr/PR8956/build3490/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=test-speaker something's wrong! Only one suspend/resume failure in CAVS https://sof-ci.01.org/sofpr/PR8956/build3491/devicetest/index.html Similar? IPC timeout in unrelated PR https://sof-ci.01.org/linuxpr/PR4851/build1842/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=multiple-pipeline-playback |
|
SOFCI TEST |
|
3rd time's the charm. ACE https://sof-ci.01.org/sofpr/PR8956/build3506/devicetest/index.html has only pause/resume issues. Luckier this time? CAVS https://sof-ci.01.org/sofpr/PR8956/build3507/devicetest/index.html has only 2 suspend/resume failures Good to go. |
marc-hb
requested review from
a team,
RanderWang,
abonislawski,
dbaluta,
fkwasowi,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko,
plbossart,
singalsu and
tlissows
as code owners
3 participants
Having to find source files to read comments is not convenient.
This depends on zephyrproject-rtos/zephyr#67019 which was merged a while ago.