app: boards: intel boards, disable winstream console #8932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable CONFIG_WINSTREAM_CONSOLE in all Intel configs that enable SOF mtrace for logging. Also disable CONFIG_LOG_BACKEND_ADSP that uses winstream as backend. No need to have two memory window based logging backends enabled at the same time. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
lyakh
reviewed
Mar 12, 2024
| CONFIG_ZEPHYR_LOG=y | ||
| CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y | ||
| CONFIG_LOG_BACKEND_ADSP=n | ||
| CONFIG_WINSTREAM_CONSOLE=n |
Collaborator
There was a problem hiding this comment.
BTW, do we need CONFIG_CONSOLE?
Collaborator
Author
There was a problem hiding this comment.
@lyakh Maybe not, but that's a bit separate discussion where to disable that. As far as I can tell, having it enabled does not bring new code to SOF build.
Collaborator
Author
|
@tobonex @lyakh @marcinszkudlinski @jsarha .. ping? |
lyakh
approved these changes
Mar 13, 2024
Contributor
|
If it just removes some content from memory window 3 then it probably won't affect my changes. |
jsarha
approved these changes
Mar 13, 2024
Contributor
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Fine by me, if nobody uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable CONFIG_WINSTREAM_CONSOLE in all Intel configs that enable SOF mtrace for logging. Also disable CONFIG_LOG_BACKEND_ADSP that uses winstream as backend. No need to have two memory window based logging backends enabled at the same time.