Add new CONFIG_DCBLOCK_HIFI and move generic XCHAL_HAVE logic to common.h #8787
Conversation
…on.h 1. The `if XCHAL_HAVE_HIFI4` macro logic is duplicated across many source files. Starting with dcblock.h, make it generic and move it to common.h 2. Add the ability to override the max available HIFI level using Kconfig Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
This is #8720 but with a Kconfig |
marc-hb
requested review from
a team,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
marc-hb
requested review from
aiChaoSONG,
andrula-song,
andyross,
cujomalainey and
singalsu
|
ACE all green except one device that was not available. https://sof-ci.01.org/sofpr/PR8787/build2264/devicetest/index.html QB all green https://sof-ci.01.org/sof-pr-viewer/#/build/PR8787/build13463361 |
| #define SOF_USE_HIFI(level, component) (SOF_CONFIG_HIFI(level, component) || \ | ||
| (SOF_CONFIG_HIFI(MAX, component) && level == SOF_MAX_XCHAL_HIFI)) | ||
|
|
||
| #ifndef __XCC__ // Cadence toolchains: either xt-xcc or xt-clang. |
There was a problem hiding this comment.
those will eventually be removed, I am fully understand you have 100% confidence on these definitions, however, it is still have possibility to have unexpected situations to handling, if introduce new bugs, then what we got(less code duplicate) is less than what we lost, just my opinion.
There was a problem hiding this comment.
Thank you @marc-hb - lets replicate for other modules.
@cujomalainey fyi - this will allow us to select HiFi level module by module to help integration and testing of upstream xtensa clang HiFi support.
| #include "dcblock.h" | ||
|
|
||
| #ifdef DCBLOCK_HIFI4 | ||
| #if SOF_USE_HIFI(4, DCBLOCK) |
There was a problem hiding this comment.
@andrula-song or anyone working with HiFi5 please make/submit this temporary change until dcblock_hifi5.c exists:
| #if SOF_USE_HIFI(4, DCBLOCK) | |
| #if SOF_USE_HIFI(4, DCBLOCK) || SOF_USE_HIFI(5, DCBLOCK) |
4 participants
The
if XCHAL_HAVE_HIFI4macro logic is duplicated across many source files. Starting with dcblock.h, make it generic and move it to common.hAdd the ability to override the max available HIFI level using Kconfig