Skip to content

Audio: DRC: DRC math function optimization #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Mar 8, 2024
Merged

Audio: DRC: DRC math function optimization #8757

lgirdwood merged 1 commit into from
Mar 8, 2024

Conversation

@andrula-song
Copy link
Contributor

@andrula-song andrula-song commented Jan 18, 2024

Use the xtense intrinsic instrunctions directly can save at least 10% cycles for those functions, and save about 0.9mcps for DRC component.

@andrula-song andrula-song mentioned this pull request Jan 18, 2024
Closed
@aiChaoSONG aiChaoSONG changed the title Audio: DRC: DRC math function optimiazation Audio: DRC: DRC math function optimization Jan 18, 2024
@lgirdwood
Copy link
Member

lgirdwood commented Jan 24, 2024

@singalsu pls review

@andrula-song andrula-song marked this pull request as ready for review January 25, 2024 10:40
@andrula-song andrula-song requested a review from a team as a code owner January 25, 2024 10:40
singalsu
singalsu requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my check with TGL the improvement was 1.7 MCPS. There's a minimal difference in the steady signal characteristics measured by process_test() in frequency response after this change (less than 0.05 dB in some frequencies) but it's so small that it's insignificant.

@andrula-song andrula-song force-pushed the drc branch 2 times, most recently from a601bdd to beb6553 Compare February 27, 2024 10:02
singalsu
singalsu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@lgirdwood
Copy link
Member

lgirdwood commented Mar 7, 2024

@andrula-song looks like a simple error to fix in build

fdata-sections -mlongcalls -DXTENSA_TOOLCHAIN_VARIANT=2 -std=c99 -std=gnu99 -MD -MT modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c.obj -MF modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c.obj.d -o modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c.obj -c /srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c: In function ‘drc_asin_fixed’:
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c:164: error: perhaps a TIE conversion macro (from ae_f32x2 to int32_t) is missing
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c:164: error: incompatible types in initialization
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c: In function ‘drc_inv_fixed’:
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c:234: error: perhaps a TIE conversion macro (from ae_f32x2 to int32_t) is missing
/srv/home/jenkins/workspace/sof_config_build/sof/src/audio/drc/drc_math_hifi3.c:234: error: incompatible types in assignment
[294/355] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_config_build/sof/src/samples/audio/smart_amp_test_ipc4.c.obj

@andrula-song
Audio: DRC: DRC math function optimization.
2cc95cd 
Use the xtense intrinsic instrunctions directly can save
at least 10% cycles for those functions, and save about
0.9mcps for DRC component.

Signed-off-by: Andrula Song <andrula.song@intel.com>
@andrula-song
Copy link
Contributor Author

andrula-song commented Mar 8, 2024

hi @wszypelt , can you help to trigger test again? only copy timeout issue
Screenshot from 2024-03-08 15-54-01

@wszypelt
Copy link

wszypelt commented Mar 8, 2024

@andrula-song sure, during 20 min there will be new results

@lgirdwood lgirdwood merged commit e48a171 into thesofproject:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShriramShastry ShriramShastry ShriramShastry left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@johnylin76 johnylin76 johnylin76 approved these changes

@singalsu singalsu singalsu approved these changes

+1 more reviewer

@cujomalainey cujomalainey cujomalainey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@andrula-song @lgirdwood @wszypelt @cujomalainey @johnylin76 @singalsu @ShriramShastry