Skip to content

buffer: refine write-back and invalidate logic for produce/consume #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jul 12, 2018
Merged

buffer: refine write-back and invalidate logic for produce/consume #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/audio/buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,20 @@ void comp_update_buffer_produce(struct comp_buffer *buffer, uint32_t bytes)

spin_lock_irq(&buffer->lock, flags);

if (buffer->source->is_dma_connected)
/*
* new data produce, handle consistency for buffer and cache:
* 1. source(DMA) --> buffer --> sink(non-DMA): invalidate cache.
* 2. source(non-DMA) --> buffer --> sink(DMA): write back to memory.
* 3. source(DMA) --> buffer --> sink(DMA): do nothing.
* 4. source(non-DMA) --> buffer --> sink(non-DMA): do nothing.
*/
if (buffer->source->is_dma_connected &&
!buffer->sink->is_dma_connected)
/* need invalidate cache for sink component to use */
dcache_invalidate_region(buffer->w_ptr, bytes);
else if (buffer->sink->is_dma_connected)
else if (!buffer->source->is_dma_connected &&
buffer->sink->is_dma_connected)
/* need write back to memory for sink component to use */
dcache_writeback_region(buffer->w_ptr, bytes);

buffer->w_ptr += bytes;
Expand Down