ipc4: Regression FIX: Do not clear sources/sinks on reset #8657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After thesofproject#8594 been merged, sources and sinks are now setup on .bind() and .unbind(). Previously they were setup in .prepare(). However, there were code left in module_adapter_reset() which clears sources and sinks arrays. That broke some tests: modules which use source/sink API stopped working correctly after pipeline reset. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
jxstelter and
ranj063
as code owners
serhiy-katsyuba-intel
requested review from
RanderWang,
kv2019i and
marcinszkudlinski
Contributor
|
good point, |
Contributor
Author
They are re-setup (overwritten) at .bind() and .unbind(). So, yes, if something been unbinded then num_of_sources/num_of_sinks and sources[]/sinks[] will be updated appropriately. |
marcinszkudlinski
approved these changes
Dec 20, 2023
lgirdwood
approved these changes
Dec 20, 2023
Contributor
Author
|
Internal Intel CI has failed on tests checkout. Been re-scheduled to run again. |
kv2019i
approved these changes
Dec 20, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Didn't realize immediately that we call the prepare function at unbind as well, so indeed this piece of code is not needed.
btian1
approved these changes
Dec 21, 2023
Member
|
@serhiy-katsyuba-intel any update on CI ? Fwiw, there was an DUT upload issue last night that blocked some PRs so worth checking if this is good to merge. |
Contributor
Author
|
@lgirdwood , @kv2019i , CI finally completed. Ready to merge. |
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #8594 been merged, sources and sinks are now setup on .bind() and .unbind(). Previously they were setup in .prepare(). However, there were code left in module_adapter_reset() which clears sources and sinks arrays. That broke some tests: modules which use source/sink API stopped working correctly after pipeline reset.