Audio: Module adapter: Fix return value when no prepare operation #8605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
The build of testbench for MTL platform simulation causes this build
fail (rebuilt-testbench -p mtl):
src/audio/module_adapter/module/generic.c:213:6:
error: variable 'ret' is used uninitialized whenever 'if'
condition is false [-Werror,-Wsometimes-uninitialized]
if (md->ops->prepare) {
^~~~~~~~~~~~~~~~
src/audio/module_adapter/module/generic.c:236:9:
note: uninitialized use occurs here
return ret;
^~~
Since it's a possibility to have a module without prepare()
operation, the initialize to zero is added to avoid the
return of undefined value.
Reported-by: Marc Herbert <marc.herbert@intel.com>
Signed-off-by: shastry <malladi.sastry@intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
module_prepare_no_prepare_operation_fix
branch
from
b0eda35 to
65464a1
Compare
lgirdwood
approved these changes
Dec 11, 2023
Member
|
Will merge here since this is a build fix. |
Collaborator
|
Just for the record: only clang seems to print this warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of testbench for MTL platform simulation causes this build fail (rebuilt-testbench -p mtl):
src/audio/module_adapter/module/generic.c:213:6:
error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (md->ops->prepare) {
^~~~~~~~~~~~~~~~
src/audio/module_adapter/module/generic.c:236:9:
note: uninitialized use occurs here
return ret;
^~~
Since it's a possibility to have a module without prepare() operation, the initialize to zero is added to avoid the return of undefined value.
Reported-by: Marc Herbert marc.herbert@intel.com