Preparation for zephyr/cmake/math transfer #8494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
This was referenced Nov 18, 2023
Collaborator
Collaborator
Author
See: There is nothing "smart" or complicated about #8260, I'm really just moving scattering CMake code away from zephyr/CMakeLists.txt into subdirectories. Anything more elaborate I should do? |
lgirdwood
reviewed
Nov 20, 2023
zephyr/CMakeLists.txt
Outdated
| endif() | ||
| endmacro() | ||
|
|
||
| # Wrappers for re-using existing, XTOS CMake files. Do NOT use in Zephyr-specific code. |
Member
There was a problem hiding this comment.
This comment might be confusing as its in the zephyr makefile ?
Fixes commit 1bd9e0d ("cmake/zephyr: decentralize src/ipc/") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
For reducing CMake duplication and centralization, see thesofproject#8260 Not used yet. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Leverage the previous commit. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This makes the code shorter and will help with thesofproject#8260 Zero functional change. Do not use it when Zephyr use is not conditional. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
cmake-math-prework
branch
from
db7854c to
812f476
Compare
lgirdwood
approved these changes
Nov 29, 2023
andyross
approved these changes
Nov 29, 2023
Contributor
andyross
left a comment
andyross
left a comment
There was a problem hiding this comment.
This scheme is looking very clean (especially given the difficulties of the source language, I guess "macro" was the magic), nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake deduplication #8260
No migration yet, just splitting the change in two to minimize review strain.