sink_src: add ipc4 update format functions #8468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinszkudlinski
force-pushed
the
sink_src_format_ext
branch
from
71873ac to
f1c8c3c
Compare
sink/src API must grow to provide similar functionality to comp_buffers. This commit adds 2 helpers for IPC4 format set Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
marcinszkudlinski
force-pushed
the
sink_src_format_ext
branch
from
f1c8c3c to
2d91c87
Compare
marcinszkudlinski
requested review from
RanderWang,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
7 tasks
RanderWang
approved these changes
Nov 10, 2023
Collaborator
RanderWang
left a comment
RanderWang
left a comment
There was a problem hiding this comment.
LGTM. The source and sink are very similar, can we unify them ?
Collaborator
|
I still prefer adding code only when it's needed, not to provide similar functionality. |
kv2019i
approved these changes
Nov 10, 2023
Contributor
Author
|
@lyakh - yes it is needed, look at 8469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sink/src API must grow to provide similar functionality to comp_buffers.
This commit adds 2 helpers for IPC4 format set